Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wally-registry-frontend Framework Migration #197

Merged
merged 27 commits into from
Nov 8, 2024
Merged

Conversation

RileyAbr
Copy link
Member

@RileyAbr RileyAbr commented Nov 8, 2024

As discussed in #191, our previous bootstrapped architecture with Parcel for wally.run has completely stalled and failed during deployment. Further investigations into trying to upgrade our codebase to work with Parcel V2--as well as additional complications with a no-config bundler in Docker environments--prompted a new direction. This PR includes a total pivot to move all of our logic from a custom-built solution to a modern Next.js project. On top of being easier to maintain, this has the added benefits of making it more clear for newcomers to contribute changes with a familiar and larger presence in the modern web ecosystem.

Otherwise, all changes should be near 1-to-1 functionality duplicates with the current wally.run. I did add in fixes from the #191 PR for visual bugs and accessibility features, as well as a few more I noticed.

If this PR looks good, we can move forward with a new deployment strategy as well!

@RileyAbr RileyAbr added the javascript Pull requests that update Javascript code label Nov 8, 2024
@RileyAbr RileyAbr requested a review from Dekkonot November 8, 2024 00:36
Copy link
Member

@Dekkonot Dekkonot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, though I can't deploy them to test. Going to save this until later because I don't feel super comfortable merging this until we can get it on the test site, haha.

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wally-registry-frontend ✅ Ready (Inspect) Visit Preview 1 resolved Nov 8, 2024 7:55pm

@Dekkonot Dekkonot merged commit 16c6b3f into main Nov 8, 2024
3 checks passed
@Dekkonot Dekkonot deleted the front-end-migration branch November 8, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants